Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rails 7 and adding features #3

Merged
merged 11 commits into from
Feb 3, 2023
Merged

Feature/rails 7 and adding features #3

merged 11 commits into from
Feb 3, 2023

Conversation

asedge
Copy link
Collaborator

@asedge asedge commented Feb 1, 2023 •
edited
Loading

  • Add support for Rails 7 and update Restforce dependency to newer version.
  • Add has_one association.
  • Model generator enhancements:
    • automatically add types to fields
    • sort fields alphabetically
    • add table_name to class
    • add optional namespace parameter so generated models can be namespaced
  • Add get/set via [] and []= for SObject attributes.

asedge added 4 commits February 2, 2023 09:24
@asedge
Add support for Rails 7. Update dependencies and namespacing for Fara…
83c5ad8 
…day errors. Bump version file. Remove codeclimate dependency.
@asedge
Add ActiveModel::Type where they can be inferred from salesforce when…
4b1de6f 
… generating model files.
@asedge
Add namespace command line option. Call classify on class name to r…
ed53dd7 
…emove underscores. Remove unneeded monkey patch and call `underscore` from ActiveSupport.
@asedge
Set the table_name in the model generator.
030b019
@asedge asedge force-pushed the feature/rails_7_and_adding_features branch from 6de9ba4 to 8a2a177 Compare February 2, 2023 14:25
@asedge asedge force-pushed the feature/rails_7_and_adding_features branch from 8a2a177 to 32ea5d8 Compare February 2, 2023 14:49
spacechurro
spacechurro reviewed Feb 3, 2023
View reviewed changes
Copy link

@spacechurro spacechurro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks slick. I'm not too savvy on how CHANGELOG.md normally gets updated, but what if we add in a bullet point summary of the public facing changes for 0.9.0 in there and then we can also include that same summary in the description of this PR? Then we should all our bases covered for where to look for info on the new gem version.

@asedge
Copy link
Collaborator Author

asedge commented Feb 3, 2023

This looks slick. I'm not too savvy on how CHANGELOG.md normally gets updated, but what if we add in a bullet point summary of the public facing changes for 0.9.0 in there and then we can also include that same summary in the description of this PR? Then we should all our bases covered for where to look for info on the new gem version.

Makes sense. I'll see if I can update the CHANGELOG today.

@asedge
Copy link
Collaborator Author

asedge commented Feb 3, 2023

@spacechurro Updated the changelog and description.

spacechurro
spacechurro requested changes Feb 3, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@asedge asedge force-pushed the feature/rails_7_and_adding_features branch 3 times, most recently from 049875c to e209f57 Compare February 3, 2023 20:30
@asedge asedge force-pushed the feature/rails_7_and_adding_features branch from e209f57 to e5febe5 Compare February 3, 2023 20:31
spacechurro
spacechurro approved these changes Feb 3, 2023
View reviewed changes
Copy link

@spacechurro spacechurro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooh. Even got some PR links in there too. Looks great. Thanks!

@spacechurro spacechurro merged commit b3cab9f into main Feb 3, 2023
@spacechurro spacechurro deleted the feature/rails_7_and_adding_features branch February 3, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacechurro spacechurro spacechurro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asedge @spacechurro