Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all parameters in RecordNotFound.new optional #44

Merged
merged 2 commits into from
May 1, 2023
Merged

Make all parameters in RecordNotFound.new optional #44

merged 2 commits into from
May 1, 2023

Conversation

rferg
Copy link
Contributor

@rferg rferg commented May 1, 2023

Parameterless constructor calls were being made in Glue tests, so we need these to be optional.

@rferg rferg marked this pull request as ready for review May 1, 2023 20:52
@rferg rferg requested a review from asedge May 1, 2023 20:52
asedge
asedge approved these changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@asedge asedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@asedge asedge merged commit d0dbb5e into main May 1, 2023
@asedge asedge deleted the fix/record-not-found-constructor branch May 1, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asedge asedge asedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rferg @asedge