Adding order method to active query to support several argument formats #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffLuckett
suggested changes
May 25, 2023
JeffLuckett
suggested changes
May 25, 2023
CHANGELOG.md
Outdated
| @@ -2,6 +2,11 @@ | |||
|
|
|||
| ## Not released | |||
|
|
|||
| ## 0.14.1 | |||
There was a problem hiding this comment.
Remove line 5, just leave it as "Not released". We'll package a few changes together before we release.
| - Add `#order` method to active query that accepts arguments in several formats ( symbol, string that has raw soql) (https://github.com/Beyond-Finance/active_force/pull/58) | ||
| - By default, the order is ascending. For descending order, you can map the column name symbol to :desc | ||
| - use-cases: User.order(:name), User.order(email: :desc), User.order(:name, email: :desc), User.order('name') | ||
|
|
There was a problem hiding this comment.
Remove line 7&8. Just need the info on line 6.
Feel free to add info to README.md if you feel additional documentation is necessary, but since this pretty much follows the AR implementation, probably not necessary.
There was a problem hiding this comment.
Got it, Would update them
JeffLuckett
approved these changes
May 26, 2023
JeffLuckett
deleted the
feature/override-order-by-to-support-symbols-and-order-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ordermethod to active query that accepts arguments in one of several formats ( symbol, string that has raw soql):descUse-cases:
User.order(:name)
User.order(email: :desc)
User.order(:name, email: :desc)
User.order('name')