Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ids method AF query #94

Merged
merged 3 commits into from
May 31, 2024
Merged

Add ids method AF query #94

merged 3 commits into from
May 31, 2024

Conversation

cdelpone-beyond-finance
Copy link
Contributor

@cdelpone-beyond-finance cdelpone-beyond-finance commented May 25, 2024 •
edited
Loading

Adds #ids method to ActiveForce::Query

Testing notes:

  • deploy to staging, in rails console, call .ids on an AF query. Result should return an array of ids with the given criteria.

@cdelpone-beyond-finance cdelpone-beyond-finance marked this pull request as ready for review May 25, 2024 01:15
@cdelpone-beyond-finance cdelpone-beyond-finance requested a review from a team May 28, 2024 19:56
@cdelpone-beyond-finance cdelpone-beyond-finance changed the title SAL-3248 | FEATURE | Add ids method AF query objects Add ids method AF query objects May 29, 2024
@cdelpone-beyond-finance cdelpone-beyond-finance changed the title Add ids method AF query objects Add ids method AF query May 29, 2024
asedge
asedge approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@asedge asedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@asedge asedge merged commit 25c1f96 into main May 31, 2024
5 checks passed
@asedge asedge deleted the SAL-3248-add-ids-method-af-query-objects branch May 31, 2024 15:23
mikelarkin pushed a commit that referenced this pull request Jul 17, 2024
@cdelpone-beyond-finance
Fixes #94 - Ids Query Method (#97)
5d1689f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asedge asedge asedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdelpone-beyond-finance @asedge @jflack-bf