interface type fixes & unit test improvements #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuke fix
|
@ITDancer13 @a-patel @Biarity @zolrath Can anyone give a review and push this down to release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
It's been a long time, I know...
This fix is in my mind for a long time. Finally I got the time to actually do it!
Current implementation relies on
IQueryable<T>whereTis a concrete type. Sometime ago I did a change and put a very small workaround when sorts fail whereTis an interface type!. This time, I did a complete rethinking about the problem and came up with this change.This fix is final with one feature is consiously left out:
Support for same property name for multiple interfaces. This version works for filters & orders, both.I also did some editings to unit tests. I'm not completely happy with all that, but maybe sometime later, somebody can do a complete re-do to that area.
Be safe, all.