fix selection bug

[aymericdelab]

Summary by CodeRabbit

• Refactor
  • Simplified selection clearing methods in the WorldmapScene by consolidating clearEntitySelection and clearHexSelection into a single clearSelection method
  • Improved code readability in the resource arrivals component by reformatting a function call

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 23, 2025 5:06pm
eternum-docs	❌ Failed (Inspect)			Jan 23, 2025 5:06pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
eternum-landing	⬜️ Ignored (Inspect)	Visit Preview		Jan 23, 2025 5:06pm

[mentatbot]

Hi @aymericdelab! You need to be added as a user to interact with me. Please ask @ponderingdemocritus to add you on the settings page.

_{You are receiving this comment because I am set to review all PRs. That is configurable here.}

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

client/apps/game/src/three/scenes/worldmap.ts

Oops! Something went wrong! :(

ESLint: 9.18.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

Walkthrough

The pull request involves two primary changes in the game's codebase. In the WorldmapScene class, method refactoring occurs by consolidating selection clearing methods into a single clearSelection method. In the resource-arrivals.tsx component, a minor formatting change is made to the getEntitiesFromTorii function call within a useEffect hook, improving code readability without altering functionality.

Changes

File	Change Summary
client/apps/game/src/three/scenes/worldmap.ts	Refactored selection clearing methods: - Removed clearEntitySelection() - Removed clearHexSelection() - Added clearSelection() method
client/apps/game/src/ui/components/trading/resource-arrivals.tsx	Reformatted getEntitiesFromTorii function call in useEffect hook for improved readability

Poem

🐰 A rabbit's code refrain, clean and bright,
Methods merged with algorithmic might
Selections cleared with elegant grace
One function now takes up the space
Simplicity hops through the lines today! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44f0db3 and 58be88f.

📒 Files selected for processing (2)

• client/apps/game/src/three/scenes/worldmap.ts (4 hunks)
• client/apps/game/src/ui/components/trading/resource-arrivals.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• client/apps/game/src/ui/components/trading/resource-arrivals.tsx

🔇 Additional comments (5)

client/apps/game/src/three/scenes/worldmap.ts (5)

193-193: LGTM!

The call to clearSelection is correctly used to handle the Escape key event.

---

199-199: LGTM!

The call to clearSelection is correctly used to handle URL changes.

---

314-314: LGTM!

The call to clearSelection is correctly used after structure placement.

---

369-372: LGTM!

The call to clearSelection is correctly used when deselecting an army.

---

385-391: Well-structured consolidation of selection clearing logic!

The new clearSelection method effectively consolidates all selection-related clearing operations into a single, well-organized method. This refactoring improves code maintainability and reduces the likelihood of inconsistent state management.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.