fix report serialization #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zargot
changed the title
Merged
yulric
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Can you update the commit message with the following information:
- Why we removed the class (because of the web tool)
- Why we can't type the TableInfo as a TypedDict instead of a class
In general, we should think about our usage of the jsons library. I think its a big issue if we can't use TypedDict in our code since we will eventually typing to this library.
zargot
changed the title
|
@yulric, I managed to make TypedDict work, and removed "jsons". |
yulric
approved these changes
Dec 12, 2023
to get rid of jsons dependency, which doesn't play along well with TypedDict (which we'll be using more and more). This change also improves the code in general.
for json serialization. Dataclass decorator is removed since it doesn't work with typeddict in python < 3.11.
zargot
force-pushed
the
report-serial
branch
from
4dac65e to
d5a3abc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TableInfo class which appears in the validation report, had to be made into a TypedDict to support normal json serialization in tools using it (namely the web validation tool).