Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using multi_easy_bin with --no-recluster #128

Closed
Ralwoss opened this issue Feb 14, 2023 · 8 comments
Closed

Error using multi_easy_bin with --no-recluster #128

Ralwoss opened this issue Feb 14, 2023 · 8 comments

Comments

@Ralwoss
Copy link

Ralwoss commented Feb 14, 2023

Hi,

I'm working with @bebatut on updating the Galaxy Wrapper for SemiBin. There was a problem using SemiBin multi_easy_bin with the parameter --no-recluster.

SemiBin multi_easy_bin \
--separator ':' \
--taxonomy-annotation-table test-data/taxonomy*.tsv \
--input-fasta test-data/input_multi.fasta.gz \
--input-bam test-data/input_multi*.bam \
--output 'output' \
--cannot-name 'cannot'  \
--ratio 0.05   \
--orf-finder 'fraggenescan' \
--random-seed 0 \
--epoches 20 \
--batch-size 2048 \
--max-node 1.0 \
--max-edges 200 \
--minfasta-kbs 200 \
--no-recluster

The error is :

Traceback (most recent call last):
  File "/home/ralwoss/anaconda3/envs/SemiBin/bin/SemiBin", line 10, in <module>
    sys.exit(main1())
             ^^^^^^^
  File "/home/ralwoss/anaconda3/envs/SemiBin/lib/python3.11/site-packages/SemiBin/main.py", line 1482, in main1
    main2(args, is_semibin2=False)
  File "/home/ralwoss/anaconda3/envs/SemiBin/lib/python3.11/site-packages/SemiBin/main.py", line 1468, in main2
    multi_easy_binning(
  File "/home/ralwoss/anaconda3/envs/SemiBin/lib/python3.11/site-packages/SemiBin/main.py", line 1270, in multi_easy_binning
    for bf in os.listdir(os.path.join(output, 'samples', sample, bin_dir_name)):
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'output/samples/S1/output_prerecluster_bins'

Without --no-recluster everything works. With --no-recluster there is no output/samples/S1/output_prerecluster_bins directory, only an output/samples/S1/output directory.

It would be great if you could take a look

@psj1997
Copy link
Collaborator

psj1997 commented Feb 28, 2023

Sorry for the late reply. I have fixed this issue.

Thanks for more feedbacks from you.

Sincerely
Shaojun

@bebatut
Copy link

bebatut commented Mar 1, 2023

Thanks for fixing it.

Would it be possible to have a release with the fix so a new conda package will be available and can be used in Galaxy wrapper? Thanks

luispedro added a commit to luispedro/SemiBin that referenced this issue Mar 7, 2023
Fix use of `--no-recluster` with multi_easy_bin, see [BigDataBiology#128](BigDataBiology#128)
@luispedro
Copy link
Member

We released a new version (v1.5.1). Conda sometimes takes a few hours for the auto-update to kick in, but it will be done later today or tomorrow. HTH, Luis

@luispedro
Copy link
Member

Maybe their bot is better because it was actually immediate: bioconda/bioconda-recipes#39775

Once those tests pass, it can be merged, so there will be a new conda version in an hour or so

luispedro added a commit that referenced this issue Mar 7, 2023
Fix use of `--no-recluster` with multi_easy_bin, see [#128](#128)
@Ralwoss
Copy link
Author

Ralwoss commented Oct 30, 2023

Hi,
this issue is back in SemiBin2.
multi_easy_bin --write-pre-reclustering-bins can not find the directory output_bins because there are output_pre_recluster_bins and output_after_recluster_bins instead of output_bins.

It would be great if you could take a look

luispedro added a commit to luispedro/SemiBin that referenced this issue Oct 31, 2023
This is an issue in the newer SemiBin2 command

/cc BigDataBiology#128
@luispedro
Copy link
Member

Thanks for the report, I can reproduce

@luispedro luispedro reopened this Oct 31, 2023
luispedro added a commit to luispedro/SemiBin that referenced this issue Oct 31, 2023
luispedro added a commit to luispedro/SemiBin that referenced this issue Oct 31, 2023
This is an issue in the newer SemiBin2 command

/cc BigDataBiology#128
luispedro added a commit to luispedro/SemiBin that referenced this issue Oct 31, 2023
luispedro added a commit to luispedro/SemiBin that referenced this issue Oct 31, 2023
luispedro added a commit to luispedro/SemiBin that referenced this issue Oct 31, 2023
Bugfix release, fixes issue BigDataBiology#128 (multi_easy_bin with --write-pre-recluster)
luispedro added a commit to luispedro/SemiBin that referenced this issue Oct 31, 2023
This was a bugfix release, fixing issue BigDataBiology#128 (multi_easy_bin with --write-pre-recluster)
@luispedro
Copy link
Member

FYI, we released a new version (2.0.2) to fix this issue. At least this particular combination of arguments is now part of our test suite and future regressions will be caught

@Ralwoss
Copy link
Author

Ralwoss commented Nov 1, 2023

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants