Feature/search filters #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toboid
force-pushed
the
feature/search_filters
branch
4 times, most recently
from
d8f6e52
to
477d376
Compare
added 13 commits
September 15, 2015 15:59
…entire JSON schema, and to ensure that swagger.json is correct
|
ooh, jumping the queue has caused me nasty very nice rebase 😢 |
toboid
force-pushed
the
feature/search_filters
branch
from
477d376
to
953bd9e
Compare
|
Bwahahaha 😈 |
| @@ -1,8 +1,7 @@ | |||
| { | |||
| "extends": "xo-space", | |||
| "extends": "xo-space/esnext", | |||
There was a problem hiding this comment.
What's the reason for using esnext?
There was a problem hiding this comment.
It's the consistency rules from xo for ES6. Tried it with iojs but that wasn't working great because some stuff was behind flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented term and range filters. It turns out that minProperties is supported despite this issue. I added basic validation that this is working ok as was finding myself having to test manually through postman