Support multi-instance mods (for M+ affixes) #1202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work. M+ affixes in LW is something I've wanted to add for a while. I'm not sure if this the best approach, but I'm leaving it open whilst I give it some thought. |
|
Replaced by #1240. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for feedback on this. The primary usecase I wanted to solve for was to allow a single mod to be written for something like a Mythic+ affix which would have just 1 entry in the options but load for all relevant instance IDs.
To get an idea of what a mod using this would look like refer to this: https://github.com/BigWigsMods/LittleWigs/compare/master...dekallo:affixes?expand=1
And a screenshot of the implementation in-game: