Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bastion/DoubleDragon: do not remove blackout timer on debuff removal #17

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

stako
Copy link
Contributor

@stako stako commented Sep 25, 2024

For the Theralion & Valiona boss fight in Cataclysm's Bastion of Twilight raid:

  • When the Blackout debuff is applied to a unit, the Blackout timer is correctly reset to 45 seconds.
  • When the same Blackout debuff is removed, the timer incorrectly is also removed - now we don't have a timer for the next Blackout.
  • Blackout timer should only be removed when entering the "Theralion on ground" phase.

Video demonstrating the issue
The BigWigs timers are in grey & white on the left side of the screen. The blue timers are from a different addon.

@funkydude funkydude changed the title fix: do not remove blackout timer on debuff removal Bastion/DoubleDragon: do not remove blackout timer on debuff removal Sep 25, 2024
@funkydude funkydude merged commit 599744b into BigWigsMods:master Sep 25, 2024
1 check passed
@funkydude
Copy link
Member

Thanks!

@stako stako deleted the blackout-fix branch November 9, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants