Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance compared to Mongoose #8

Open
zacharynevin opened this issue Jun 24, 2014 · 6 comments
Open

Performance compared to Mongoose #8

zacharynevin opened this issue Jun 24, 2014 · 6 comments

Comments

@zacharynevin
Copy link

I made a minor addition to my initial pull request (small error where leftKeys.split('.') should have been leftKeys[0].split('.')) and it works perfectly on my system in doing nested joins.

My question is: do you know the performance of this compared to the ad-hoc joins performed in Mongoose? I never cared much for ORMs or ODMs, but I was just curious.

@khous
Copy link
Contributor

khous commented Jun 24, 2014

I don't know offhand what the performance difference is. Also sorry about
the delay in accepting the merge request.
On Jun 23, 2014 8:46 PM, "zacharynevin" notifications@github.com wrote:

I made a minor addition to my initial pull request (small error where
leftKeys.split('.') should have been leftKeys[0].split('.')) and it works
perfectly on my system in doing nested joins.

My question is: do you know the performance of this compared to the ad-hoc
joins performed in Mongoose? I never cared much for ORMs or ODMs, but I
was just curious.


Reply to this email directly or view it on GitHub
#8.

@zacharynevin
Copy link
Author

I notice as well that there is no way to select the columns wanted from the joining collection. I can create a new pull request for this.

@khous
Copy link
Contributor

khous commented Jun 24, 2014

Yeah that's a good idea. A lot of web frameworks support field filtering.
On Jun 23, 2014 8:55 PM, "zacharynevin" notifications@github.com wrote:

I notice as well that there is no way to select the columns wanted from
the joining collection. I can create a new pull request for this.


Reply to this email directly or view it on GitHub
#8 (comment)
.

@zacharynevin
Copy link
Author

Yeah it would be especially useful if you are joining on a user's table, which is probably the most common use case for this.

@zacharynevin
Copy link
Author

At first glance it looks like I just need to add a projection operator to the getSubqueries function. Does this sound correct?

@khous
Copy link
Contributor

khous commented Jun 24, 2014

Not sure. I'm on my phone right now, but yes a projection will work. As
long as the join fields are returned as well.
On Jun 23, 2014 9:00 PM, "zacharynevin" notifications@github.com wrote:

At first glance it looks like I just need to add a projection operator to
the getSubQueries function. Does this sound correct?


Reply to this email directly or view it on GitHub
#8 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants