-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF data as .json files #29
Comments
@sbillinge: @berrakozer and I tried to inspect and explore the .json files provided by Simon Westrip. Initially, we just used pandas.read_json() to read the jsons into pandas dataframes. Of course, we may do that in another way down the road. We tried to do some initial plotting to explore how to access values in the dataframe. Considering the architecture and content of the jsons, we can definitely get inspiration to our own object to create. However, I guess we would like some more 'consistency' in our own object, e.g. 495 cifs don't contain Q-values. This was realized by identifying all the possible keys, containing either 'Q' or 'q': If interested, I have attached the .py file used. |
I think this is good but I am not sure we want to put time into this right
now. My comments were just to basically file everything away so we don't
have to think about it, but don't lose it.....
…On Thu, Jun 10, 2021 at 5:25 PM Martin Aaskov Karlsen < ***@***.***> wrote:
@sbillinge <https://github.com/sbillinge>: @berrakozer
<https://github.com/berrakozer> and I tried to inspect and explore the
.json files provided by Simon Westrip. Initially, we just used
pandas.read_json() to read the jsons into pandas dataframes. Of course, we
may do that in another way down the road. We tried to do some initial
plotting to explore how to access values in the dataframe.
Considering the architecture and content of the jsons, we can definitely
get inspiration to our own object to create. However, I guess we would like
some more 'consistency' in our own object, e.g. 495 cifs don't contain
Q-values. This was realized by identifying all the possible keys,
containing either 'Q' or 'q':
_pdcifplot_pd_proc_2theta_corrected,Q
_pdcifplot_pd_proc_d_spacing,Q
*pdcifplot_pd_meas_2theta_range*,Q
*pdcifplot_pd_proc_2theta_range*,Q
_pdcifplot_pd_meas_2theta_scan,Q
_pdcifplot_pd_meas_2theta_corrected,Q
If interested, I have attached the .py file used.
json_plot.zip
<https://github.com/Billingegroup/pydatarecognition/files/6634505/json_plot.zip>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUKBE4DPMJE2L7ALWYDTSEUS7ANCNFSM46PCI4UA>
.
--
Simon Billinge
Professor, Columbia University
Physicist, Brookhaven National Laboratory
|
@sbillinge: got it. We will leave it for now. |
@sbillinge @maak-sdu: Added the .json file to my lion mail google drive and sent invites to you both. |
great, thank you.
…On Thu, Jun 10, 2021 at 9:09 PM berrakozer ***@***.***> wrote:
@sbillinge <https://github.com/sbillinge> @maak-sdu
<https://github.com/maak-sdu>: Added the .json file to my lion mail
google drive and sent invites to you both.
Google drive url is the following:
https://drive.google.com/drive/u/1/folders/1QkuqjRSSlcmC6kVa7KjJWvmjgDGOoYw6
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUOH3NDCFRTLQUH4KDLTSFO3TANCNFSM46PCI4UA>
.
--
Simon Billinge
Professor, Columbia University
Physicist, Brookhaven National Laboratory
|
We should capture this somewher in our planning.
This is a direction we want to go in (document backend). It would involve modifying our load_cif capabilities. I would rather put this off for now, but maybe we should make an issue to return to this sometime later. Please could one of you do that, and copy paste the email contents in there. Perhaps we should archive the data somewhere safe (Columbia Google drive with the url captured in the issue maybe?)
Thx
S
---------- Forwarded message ---------
From: Simon Westrip simonwestrip@btinternet.com
Date: Fri, Jun 4, 2021 at 11:29 AM
Subject: MRLP - some more test data
To: Nicola Ashcroft na@iucr.org, Simon Billinge sb2896@columbia.edu, Berrak Ozer bo2220@columbia.edu, Martin Karlsen maak@sdu.dk, Peter Strickland ps@iucr.org, Brian McMahon bm@iucr.org, Koh Song Sang koh@iucr.org, Dave Holden dh@iucr.org
Hopefully the following may be of use:
The zip file at https://publbio.iucr.org/services/tools/pdcifplot/cache/json.zip contains a collection of .json files which each contain an array of objects that contain 'pdcifplot' data, i.e. each object contains processed data corresponding to a datablock in a source CIF.
Although these objects are tailored for use in the online pdcifplot application, they could form the basis of a database of powder patterns, but obviously with additional fields optimized for input to the pydatarecognition script and for search purposes...
The json structure for each datablock is outlined below (this is not 'set in stone'):
{
// minimal metadata:
}
NB This is not 'CIF-JSON'. In CIF-JSON data blocks are named properties of a CIF-JSON object rather than an array of objects. In addition CIF-JSON specifies that all properties describing CIF data items are arrays and all numeric data should be quoted as strings.
Cheers
Simon
The text was updated successfully, but these errors were encountered: