Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes grammar conflicts pr #27

Merged
merged 5 commits into from
May 13, 2021
Merged

Removes grammar conflicts pr #27

merged 5 commits into from
May 13, 2021

Conversation

ivg
Copy link
Member

@ivg ivg commented May 13, 2021

Removes 11 shift/reduce conflicts in total:

Two conflicts were related to excessive EOF tokens.
One due to volatile keyword in a function prototype before an assembly string
(solved by inlining)
Eight conflicts happen because empty strucutres (resolved by moving up)

The grammar was also reindented (still not fully) and cleaned by using more readable syntax available from the Menhir standard library.

P.S. this is a second attempt, I have accidentally squashed #25 but I want to have all commits intact to be able to bisect possible regressions.

@ivg ivg merged commit 103994d into master May 13, 2021
@ivg ivg deleted the removes-grammar-conflicts-PR branch May 13, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant