Fixes for LLVM 17 (as well as LLVM 16)

BinaryAnalysisPlatform · Feb 15, 2024 · dca1b82 · dca1b82
1 parent 511b64c
commit dca1b82
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 2 deletions.
diff --git a/lib/bap_llvm/llvm_disasm.cpp b/lib/bap_llvm/llvm_disasm.cpp
@@ -27,17 +27,22 @@
 
 #include <cstring>
 #include <cstdint>
-#include <limits>
-#include <typeinfo>
 #include <iostream>
+#if LLVM_VERSION_MAJOR >= 16
+#include <optional>
+#endif
 
 #include "disasm.hpp"
 #include "llvm_disasm.h"
 
 #include <llvm/MC/MCDisassembler/MCDisassembler.h>
 
 #include <llvm/ADT/ArrayRef.h>
+#if LLVM_VERSION_MAJOR >= 17
+#include <llvm/TargetParser/Triple.h>
+#else
 #include <llvm/ADT/Triple.h>
+#endif
 #include <llvm/ADT/Twine.h>
 
 template <typename T>
@@ -464,7 +469,12 @@ class llvm_disassembler : public disassembler_interface {
         } else if (p == is_true) {
             return true;
         } else {
+#if LLVM_VERSION_MAJOR >= 16
+            // MCInstrDesc needs to know its own address to access some implicit tables.
+            auto &d = ins_info->get(current.code);
+#else
             auto d = ins_info->get(current.code);
+#endif
             if (p == may_affect_control_flow) {
                 return d.mayAffectControlFlow(mcinst, *reg_info);
             } else if (auto check = fun_of_pred(p)) {
@@ -652,7 +662,11 @@ struct create_llvm_disassembler : disasm_factory {
 
 static void parse_environment_options(const char *prog_name, const char *env_var) {
 #if LLVM_VERSION_MAJOR >= 12
+#if LLVM_VERSION_MAJOR >= 16
+    std::optional<std::string> env_value = llvm::sys::Process::GetEnv(llvm::StringRef(env_var));
+#else
     llvm::Optional<std::string> env_value = llvm::sys::Process::GetEnv(llvm::StringRef(env_var));
+#endif
     if (!env_value)
         return;
 

diff --git a/lib/bap_llvm/llvm_loader_utils.hpp b/lib/bap_llvm/llvm_loader_utils.hpp
@@ -5,7 +5,11 @@
 #include <iomanip>
 #include <iostream>
 
+#if LLVM_VERSION_MAJOR >= 17
+#include <llvm/TargetParser/Triple.h>
+#else
 #include <llvm/ADT/Triple.h>
+#endif
 
 #include "llvm_error_or.hpp"
 

diff --git a/lib/bap_llvm/llvm_primitives.cpp b/lib/bap_llvm/llvm_primitives.cpp
@@ -1,6 +1,11 @@
 #include <iostream>
 
+#include <llvm/Config/llvm-config.h>
+#if LLVM_VERSION_MAJOR >= 17
+#include <llvm/TargetParser/Triple.h>
+#else
 #include <llvm/ADT/Triple.h>
+#endif
 
 #include "llvm_primitives.hpp"