Skip to content

Commit

Permalink
fixes the core-theory plugin semantics tags (#1421)
Browse files Browse the repository at this point in the history
This fix will ensure that if anything is changed in the core theory
configuration, then it will be reflected in the output of
disassembly.

Semantic tags describe the set of features that are provided by a
plugin. The caching subsystem relies on them to properly identify the
program context and capture it in the context digest that is used to
store and retrieve caches. Before this fix, there were no intersection
between the tags that describe the disassembler requires (uses) and
the set of tags that the core-theory plugin provides.
  • Loading branch information
ivg authored Feb 4, 2022
1 parent bf1a107 commit e52449e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion plugins/core_theory/core_theory_main.ml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ let herbrand_provides = [
"lisp";
"debug";
"core:eff";
"core:val"
"core:val";
"lifter";
"semantics";
"symbolizer";
]

let decide_name_from_possible_name () : unit =
Expand Down
1 change: 1 addition & 0 deletions plugins/disassemble/disassemble_main.ml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ include Self()
open Bap_main

let features_used = [
"semantics";
"function-starts";
"disassembler";
"lifter";
Expand Down

0 comments on commit e52449e

Please sign in to comment.