prunes Primus leave events on abnormal evaluation #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR we were emitting the `leave-*` events even when a term didn't evaluate normally (but instead raised an exception). As a result event handlers were invoked in the context where the term was partially (if at all evaluate), while they were expecting that the evaluation was successful. This led to a few undefined variables and other errors. Even worse, since the `leave-*` events were posted in the exception handler, it was possible for the event handler to raise an exception on its own, which was escaping the original exception handler and breaking havoc and significantly affecting performance.
ivg
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR we were emitting the
leave-*events even when a termdidn't evaluate normally (but instead raised an exception). As a result
event handlers were invoked in the context where the term was partially
(if at all evaluate), while they were expecting that the evaluation was
successful. This led to a few undefined variables and other errors.
Even worse, since the
leave-*events were posted in the exceptionhandler, it was possible for the event handler to raise an exception on
its own, which was escaping the original exception handler and breaking
havoc and significantly affecting performance.