runs ALL the unit tests on Travis #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out that we don't launch all the available unit tests on Travis. The reason is that we can't launch tests by running `make test` target on travis, because we use stages and don't even have a code on the stage with unit tests. Instead, we install tests executables on the build stage and then manually launch them on the other stages. And for some reason we install and run only the most important one but not all of them. This PR fixes it and run all the tests we currently have.
ivg
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that we are not running all the available unit tests on Travis.
We can't launch our unit tests just by running
make teston Travis, because we use stages and don't even have a code on the stage with unit tests. Instead, we have to install test executables on thebuild stage and then manually launch them on the next stage. And for some reason, we install and run only the most important one but not all of them.
This PR fixes it and run all the tests we currently have.