fixes a plugin initialization issue in baptop, restores postinstall #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivg
force-pushed
the
fixes-baptop
branch
2 times, most recently
from
0b99db9 to
41d9427
Compare
For some yet to be discovered reasons plugins weren't evaluated during the baptop utility startup. The were loaded, linked, but no side-effects occured. Not sure what is going in utop internals, but just loading the "bap.top" library works fine, and it is also simplifies the implementation. I've also restored the postinstall hook, that installs manpages for bap and utilities. The utilities (such as old baptop script and ppx-bap) are no longer installed, because they are obsolete, but the man pages are now installed (and now in a proper place). The postisntall hook is moved to the Makefile, since it has to be run after plugins are installed. It is predicated with the existence, so it won't be run on each package installation during opam installation, only for the bap-std package which actually produces this file. Right now, I've disabled the installation of the `bap-byteweight` manpage, since it could be only installed if the corresponding utility is installed (so we have to create a separate post-install for this package).
gitoleg
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some yet to be discovered reasons plugins weren't evaluated during
the baptop utility startup. The were loaded, linked, but no
side-effects occured. Not sure what is going in utop internals, but
just loading the "bap.top" library works fine, and it is also
simplifies the implementation.
I've also restored the postinstall hook, that installs manpages for
bap and utilities. The utilities (such as old baptop script and
ppx-bap) are no longer installed, because they are obsolete, but the
man pages are now installed (and now in a proper place).
The postisntall hook is moved to the Makefile, since it has to be run
after plugins are installed. It is predicated with the existence, so
it won't be run on each package installation during opam installation,
only for the bap-std package which actually produces this file.
Right now, I've disabled the installation of the
bap-byteweightmanpage, since it could be only installed if the corresponding utility
is installed (so we have to create a separate post-install for this package).