Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevents cmdliner from fetching plugins path from environment #1045

Merged

Conversation

ivg
Copy link
Member

@ivg ivg commented Feb 6, 2020

When this option is set, and the -L or --plugin-path option
is not used, then plugins path will be fetched from the enviroment
variable. However, the plugins library will also look at the same
variable and add the same set of paths to the search. Since this
variable should be local to the plugins library, and in fact is a
part of its interface we should just remove this from the bap-main
command line interface.

Fixes #1044

When this option is set, and the `-L` or `--plugin-path` option
is not used, then plugins path will be fetched from the enviroment
variable. However, the plugins library will also look at the same
variable and add the same set of paths to the search. Since this
variable should be local to the plugins library, and in fact is a
part of its interface we should just remove this from the bap-main
command line interface.
@ivg ivg merged commit 6efba4d into BinaryAnalysisPlatform:master Feb 6, 2020
@ivg ivg deleted the fixes-doubling-of-the-plugindir branch June 10, 2020 12:33
@ivg ivg restored the fixes-doubling-of-the-plugindir branch June 10, 2020 12:33
@ivg ivg deleted the fixes-doubling-of-the-plugindir branch June 10, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot specify plugin location with env var BAP_PLUGIN_PATH
2 participants