fixes an infinite loop in certain Primus Lisp analyses #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since now Primus Lisp operations are expressed in terms of the Primus interpreter (in order to enable analysis of the code that is stubbed in Primus Lisp), we have the `eval-cond` signal sent every time we make any comparison operation in Lisp, e.g., `if`, `when`, `or`, `and`, etc. Therefore, any method for `eval-cond` that does any comparison operation (branching) will stall in an infinite loop. A workaround is to use another observation that occurs only on jumps that are situated in the binary code, but in general we shall address it and make sure that `eval-cond` method is usable.
ivg
changed the title
ivg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since now Primus Lisp operations are expressed in terms of the Primus
interpreter (in order to enable analysis of the code that is stubbed
in Primus Lisp), we have the
eval-condsignal sent every time wemake any comparison operation in Lisp, e.g.,
if,when,or,and, etc. Therefore, any method foreval-condthat does anycomparison operation (branching) will stall in an infinite loop.
A workaround is to use another observation that occurs only on jumps
that are situated in the binary code, but in general we shall address
it and make sure that
eval-condmethod is usable.fixes (as a workaround) #1121