fixes barrier instructions with delay slots #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During disassembling we are processing instructions in linear order not execution and to detect if there is a fallthrough we were looking at the `barrier` property of the last disassembled instruction, which, in case of MIPS and other architectures with delay slots, wasn't even a jump. Instead, we should look into the disassembler state in which we have recording for each barrier and which is even faster.
gitoleg
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During disassembling we are processing instructions in the linear
not execution order and to detect if there is a fallthrough we were looking
at the
barrierproperty of the last disassembled instruction, which,in case of MIPS and other architectures with delay slots, wasn't even
a jump.
Instead, we should look into the disassembler state in which we have
recording for each barrier and which is even faster.