creates a separate package for the strings plugin #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PR removes strings plugin from `beagle` package and introduce a new package `bap-beagle-strings` for it
ivg
requested changes
Jul 6, 2020
There was a problem hiding this comment.
Do not move the strings plugin, it will break the command-line interface and make it ugly. Create a separate oasis file for the strings plugin (that will be governed by the strings plugin) and change the oasis file of the bap-strings library, which will be now governed by the strings-library flag.
oasis/beagle-strings
Outdated
| @@ -0,0 +1,12 @@ | |||
| Flag beagle_strings | |||
| Description: Build string analysis library | |||
There was a problem hiding this comment.
It is not a library but a plugin. The description would be Build the strings plugin
ivg
approved these changes
Jul 7, 2020
gitoleg
added a commit
to gitoleg/opam-repository
that referenced
this pull request
Jul 7, 2020
introduces `bap-beagle-strings` package see BinaryAnalysisPlatform/bap#1171 for details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR removes strings plugin from
beaglepackage and introduce a newpackage
bap-beagle-stringsfor it