implements support for ARM Modified Immediate Constants #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivg
force-pushed
the
arm-modified-immediate-constants
branch
2 times, most recently
from
a44ed90 to
dc17898
Compare
Surprisingly we didn't support them, only when an explicit shift was used.
ivg
force-pushed
the
arm-modified-immediate-constants
branch
from
dc17898 to
22c2d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, we did not support them so far and they are being used extensively in the PLT sequences thus preventing us from properly applying the relocations.
For the reference, see the ARM Architecture Reference Manual, ARMv7-A and ARMv7-R edition, section A4.4.1 ("Standard data-processing instructions").