adds a proper handling of unitialized memory in Primus.Memory.map #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a bug in the Primus.Memory.map function that was triggered when it is called before the current memory descriptor is properly initialized. Instead of creating a new empty state it was just silently ignoring the `map` operation. The bug was also affecting the `Primus.Memory.del` operation, for which such behavior (i.e., ignoring) is probably fine. The new implementation fixes the update function used by both, map and del to prevent any further misuses of this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the Primus.Memory.map function that was
triggered when it was called before the current memory descriptor is
properly initialized. Instead of creating a new empty state it was
just silently ignoring the
mapoperation. The bug was also affecting thePrimus.Memory.deloperation, for which such behavior (i.e.,ignoring) is probably fine. The new implementation fixes the update
function used by both, map and del to prevent any further misuses of
this function.