fixes the callgraph formation procedure in Primus Lisp typechecker #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call graph wasn't correctly closed and there were unreachable components. That resulted in missing type errors as the typing information from some nodes never reached the exit node. Fixes BinaryAnalysisPlatform#1223
ivg
force-pushed
the
fixes-lisp-type-checker-callgraph
branch
from
0b2b50f to
ac569b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call graph wasn't correctly closed and there were unreachable
components. That resulted in missing type errors as the typing
information from some nodes never reached the exit node.
Fixes #1223