fixes two bugs in the Memory module #1272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first bug was breaking the raw loader at least. It bug was
introduced in #1178 during the
Memory.view
optimization. A check wasmissed that allowed for creation of invalid views. The invalid views
later were caught with an assertion check, (easily reproduced with
bap /bin/ls --loader=raw
), e.g.,The second bug was probably all the time in the library and concerns
Memory.find_map
andMemory.find_if
, which are talking an optionalword_size
parameter that was ignored and functions were alwaysiterating over bytes.