fixes, cleans, and optimizes KB AVL tree implementation #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those optimizations are giving results only on micro benchmarks but do not affect real-life program in any sensible manner. Given how complex they are it is better to remove them.
this improves utilization of leaves and reduces the average rank of the trees.
this also results in better utilization of leaves
ivg
force-pushed
the
fixes-and-optimizes-kb-tree-implementation
branch
from
11366c1 to
ff795cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all this PR fixes a bug in the tree insertion function that was triggered under rare but possible conditions.
When the bug is triggered it may result in the information loss or in stalling the program in the infinite loop.
Also, since I was there, I've removed some micro-optimizations that didn't affect real-world applications (but were significantly
complicating the implementation). I also optimized the merge or order functions that are heavily used and were implemented rather
naively. These optimizations gave about 10% of performance improvement.