fixes a bug in the method that computes C padding. #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the code assumes that `x mod m` is multitude of `m` and raises an exception when it doesn't happen (quite often in fact). The code is called when a structure size is computed. The main caveat here is that 1) this method has incorrect type as it constrains the padding size to be in the set of `8,16,32,64,128,256` but real padding may have any number of bits (it is their sum that should in this range). 2) this method shouldn't exist at all as the padding is fully defined by the alignment of the field and there is no need to override it. Therefore, the solution is to deprecated this method and compute padding using the alignment information only. The method is no longer used and any code that overrode it will get a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the code assumes that
x mod mis multitude ofmand raises an exception when it doesn't happen (quite often infact).
The code is called when a structure size is computed. The main caveat
here is that
be in the set of
8,16,32,64,128,256but real padding may have anynumber of bits (it is their sum that should in this range).
by the alignment of the field and there is no need to override it.
Therefore, the solution is to deprecated this method and compute
padding using the alignment information only. The method is no longer
used and any code that overrode it will get a warning.