few x86 enhancements #922
Merged
few x86 enhancements #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) adds `endbr` instructions Despite that we implement these instructions as no-op, they still are very important for cfg integrity, since they usually appear in the begining of functions. 2) adds call instructions with operand override prefix. Previously, we were lifting `call` instructions only if no prefixes present. But `x86_disasm` does all the job needed for prefix comprehension (at least in part of operand overriding).
ivg
reviewed
Feb 15, 2019
| module IA32 = X86_backend.IA32 | ||
| module AMD64 = X86_backend.AMD64 | ||
|
|
||
| type endbr = [ `ENDBR32 | `ENDBR64 ] [@@deriving bin_io, sexp, compare, enumerate] |
added special statement to `endbr` Bil
ivg
approved these changes
Feb 18, 2019
|
you can merge as soon as Travis approves :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds a couple of x86 instructions:
adds
endbrinstructionsDespite that we implement these instructions as
noop, they still are very important for cfg integrity,since they usually appear in the beginning of functions.
adds call instructions with operand override prefix.
Previously, we were lifting
callinstructions only if no prefixes present. Butx86_disasmdoes all thejob needed for prefix comprehension (at least in part of operand overriding).
Few examples:
fix #901