updates vagrant/docker files #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivg
requested changes
Feb 27, 2019
docker/debian/testing/Dockerfile
Outdated
| @@ -1,16 +1,50 @@ | |||
| FROM ocaml/opam:debian | |||
| FROM debian:stretch | |||
There was a problem hiding this comment.
don't they have vagrant images for the new opam, really?
docker/trusty/testing/Dockerfile
Outdated
| @@ -1,6 +1,8 @@ | |||
| FROM ubuntu:trusty | |||
| MAINTAINER Ivan Gotovchits <ivg@ieee.org> | |||
| RUN apt-get -y update && apt-get -y install \ | |||
|
|
|||
| RUN apt-get -y update | |||
There was a problem hiding this comment.
nay, they are in a one RUN for a reason. Docker caches each RUN line, so it won't do update again, and will proceed directly to install, which will lead to missing dependencies.
docker/xenial/testing/Dockerfile
Outdated
| @@ -1,6 +1,8 @@ | |||
| FROM ubuntu:xenial | |||
| MAINTAINER Ivan Gotovchits <ivg@ieee.org> | |||
| RUN apt-get -y update && apt-get -y install \ | |||
|
|
|||
| RUN apt-get -y update | |||
vagrant/jessie64/Vagrantfile
Outdated
|
|
||
| echo "" | sh <(curl -sL https://raw.githubusercontent.com/ocaml/opam/master/shell/install.sh) | ||
|
|
||
| sudo sysctl kernel.unprivileged_userns_clone=1 |
gitoleg
force-pushed
the
updates-virtual-env
branch
from
4064ae4 to
c3e977c
Compare
ivg
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates vagrant/docker files due to new
opamversion.Note, that
sanboxingis disabled in docker files.