fixes TOCTOU bug in bap log #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivg
requested changes
Mar 28, 2019
ivg
approved these changes
Mar 28, 2019
ivg
requested changes
Mar 29, 2019
lib/bap/bap_log.ml
Outdated
| @@ -54,13 +54,26 @@ let print_message ppf msg = | |||
| | Error -> eprintf "%s@\n%!" msg.message | |||
| | _ -> () | |||
|
|
|||
| let lock () = | |||
| let file = Filename.get_temp_dir_name () / "bap_lock" in | |||
There was a problem hiding this comment.
bap.lockis a much more conventional name- this lock file would be global to all users, so my suggestion is to encode in the name of the lock file the path to the folder, that you're trying to create, salted with bap-prefix, the simplest idea is to take the digest of the path, e.g,
let lock_filename logdir =
let digest = Md5.digest_string logdir in
let name = sprintf "bap-%s.lock" (Md5.to_hex digest) in
Filename.get_temp_dir_name () / name
ivg
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #722