gdb-xml: add tricore.xml #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please take a look and see if there are any other areas that need revision. |
Rot127
requested changes
Oct 23, 2025
| static void plugin_exit(qemu_plugin_id_t id, void *udata) { | ||
| flush_all_frame_bufs(); | ||
| qemu_plugin_outs("Exiting plugin, flushing data...\n"); | ||
| // flush_all_frame_bufs(); |
There was a problem hiding this comment.
Please document why it is commented out. Or even better, open an issue and link it here.
Also change the log message, because it doesn't flush the data anymore.
| @@ -0,0 +1,77 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
Please add a comment here where you got it from or if you created it and with what reference. Also for the other xml files.
|
Would you mind fixing the build error? Should be just a simple install of dependencies. |
Co-authored-by: Rot127 <45763064+Rot127@users.noreply.github.com>
…nhance documentation
…softmmu in target list
Rot127
approved these changes
Oct 23, 2025
…(unused)) (#1) Co-authored-by: b1llow <24983369+b1llow@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Rot127
approved these changes
Oct 24, 2025
|
@b1llow Sorry, last thing. Can you please add TriCore to the "known to work" list in the main README.md? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gdb-xml: add tricore.xml
link: BinaryAnalysisPlatform/bap-frames#29