Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this properly resolve relative and non-aliased partials? #1

Open
mrjoelkemp opened this issue May 12, 2016 · 2 comments
Open

Does this properly resolve relative and non-aliased partials? #1

mrjoelkemp opened this issue May 12, 2016 · 2 comments

Comments

@mrjoelkemp
Copy link

I'm curious as to whether or not we'd need to also take in at least a filename (the file that contains the partial/moduleName).

This way, if the partial is ../bar (and the filename is /js/foo.js), we'd need that partial to resolve to /bar.js. I'm not sure that this is currently possible.

@ghost
Copy link

ghost commented May 17, 2016

I'm not sure what you mean with this. Can you give a more concrete example?

@mrjoelkemp
Copy link
Author

No worries. I'll fork it and try it out. I'm basically asking if var resolvedPath = systemResolver('node_modules/stacktrace-js/dist/stacktrace.js', 'test/data/system.config.js', new Builder()); would resolve properly.

I'm also curious if the config has to be mandatory or if could be optional. If a user has no aliased paths, do they still need a config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant