Improved documentation, test mode #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bamboo changed the API signature for bamboo 2.0.0 for adapters. deliver/2 must now return an :ok or :error tuple. Since we are delegating to the next adapter and only updating the config, we can leave that change to the downstream adapter. The other change is that the adapter must implement supports_attachments?/0. Since we delegate, we don't know if we support attachments. Since the function must be there and we have no access to the data to say if attachments are supported, I've decided always to return true. Closes BinaryNoggin#4
|
@adkron I've tested this in a pretty large production environment and it works with latest Bamboo and allows complete setup of the chained adapter at runtime. It would be great if you could take this and do a fresh release. |
|
Thanks, @colmben. This is good work. I'm going to release it momentarily. |
adkron
added a commit
that referenced
this pull request
Aug 8, 2023
* Adds support for Bamboo 2.0.0 Bamboo changed the API signature for bamboo 2.0.0 for adapters. deliver/2 must now return an :ok or :error tuple. Since we are delegating to the next adapter and only updating the config, we can leave that change to the downstream adapter. The other change is that the adapter must implement supports_attachments?/0. Since we delegate, we don't know if we support attachments. Since the function must be there and we have no access to the data to say if attachments are supported, I've decided always to return true. Closes #4 * initial work * more doco and test_mode --------- Co-authored-by: Amos L King <amos@binarynoggin.com>
adkron
added a commit
that referenced
this pull request
Aug 8, 2023
* Adds support for Bamboo 2.0.0 Bamboo changed the API signature for bamboo 2.0.0 for adapters. deliver/2 must now return an :ok or :error tuple. Since we are delegating to the next adapter and only updating the config, we can leave that change to the downstream adapter. The other change is that the adapter must implement supports_attachments?/0. Since we delegate, we don't know if we support attachments. Since the function must be there and we have no access to the data to say if attachments are supported, I've decided always to return true. Closes #4 * initial work * more doco and test_mode * Fixed failing tests - Amos --------- Co-authored-by: Amos L King <amos@binarynoggin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A general tidy :