Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can selected word be different from the same word? #157

Closed
ray0324 opened this issue Nov 11, 2017 · 8 comments
Closed

can selected word be different from the same word? #157

ray0324 opened this issue Nov 11, 2017 · 8 comments
Assignees

Comments

@ray0324
Copy link

ray0324 commented Nov 11, 2017

qq20171111-231115 2x

@Binaryify
Copy link
Owner

Binaryify commented Nov 20, 2017

could you provide some code

@darsain
Copy link

darsain commented Jan 5, 2018

I think the issue here is that these 2 colors are the same, which is pretty bad usability vise:

    "editor.selectionBackground": "#484e5b",
    "editor.selectionHighlightBackground": "#484e5b",

Forced me to do manual tweaking via workbench.colorCustomizations which I really dislike doing.

@Binaryify
Copy link
Owner

will consider it

@Binaryify
Copy link
Owner

@darsain
what color do you think will be better

@darsain
Copy link

darsain commented Jan 12, 2018

I've set it for myself to these colors:

"editor.selectionBackground": "#67769660",
"editor.selectionHighlightBackground": "#ffffff10",

Which looks like this:

image

I'm using colors with alpha channel due to recommendations in this issue: microsoft/vscode#34105

@Binaryify
Copy link
Owner

@ray0324 @darsain
I had update it, please check if it's better

@darsain
Copy link

darsain commented Jan 15, 2018

👍

@svipas
Copy link
Contributor

svipas commented Mar 13, 2018

I can't reproduce this issue I believe it can be closed?

/cc @ray0324 @darsain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants