Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searched word and highlighted word are the same #166

Closed
Ivkaa opened this issue Dec 13, 2017 · 10 comments
Closed

Searched word and highlighted word are the same #166

Ivkaa opened this issue Dec 13, 2017 · 10 comments

Comments

@Ivkaa
Copy link

Ivkaa commented Dec 13, 2017

When I want to rewrite something I searched for, when I select the area, the color of background highlight from searching is same as my highlighted part, which is very confusing, because I don't know what I highlighted. In this example I highlighted the argument in function.
image

@Ivkaa Ivkaa changed the title Searched word and highlighted word Searched word and highlighted word are the same Dec 13, 2017
@darsain
Copy link

darsain commented Jan 5, 2018

Also bugged me a lot (among other similar colors issues this theme has) so I did a bit of digging, and it seems to be a deeper issue upstream: microsoft/vscode#34105

But as suggested, even before it's solved it's still possible to add visual cues by using colors with transparency, since these selection/findMatch backgrounds are overlayed on top of each other.

@Binaryify
Copy link
Owner

I had improve it in the new version, please update and check it if it's better

@darsain
Copy link

darsain commented Jan 15, 2018

Selection highlight is still indistinguishable from search highlight for me.

@Binaryify
Copy link
Owner

have not idea, do you have any advice @darsain

@darsain
Copy link

darsain commented Jan 15, 2018

As explained in microsoft/vscode#34105, the problem here is that search highlight background is above selection highlight background, or maybe the other way around and they are the same colors, one of the two. Solution until this gets some better handling in vscode is using colors with alpha channel. That way even if 2 backgrounds are on top of each other they are still distinctive since the colors will "amplify" one another.

I don't have a specific color scheme to use here though. There is a lot of highlight variables in theming vscode. It'd require some playing around and tweaking.

@Binaryify
Copy link
Owner

@darsain
if you have some good color scheme, could you let me know, and I will improve it

@LukasPolak
Copy link
Contributor

hi, @Binaryify it is possible to make an options for example:

  • editor.selectionHighlightBorder
  • editor.wordHighlightBorder
  • editor.findMatchHighlightBorder
  • editor.findRangeHighlightBorder
  • editor.lineHighlightBorder
  • editor.rangeHighlightBorder

to see the difference for highlighting? thanks

@ghost
Copy link

ghost commented Mar 5, 2018

@Ivkaa @darsain @LukasPolak @Binaryify created this issue: #194 which will improve word highlighting after 1.21 version will be released. Stay tuned :)

@svipas
Copy link
Contributor

svipas commented Mar 8, 2018

Bad news, seems there's no such thing like editor.selectionBorder which is for selected text with mouse.

Good news I created issue in VS Code: microsoft/vscode#45292

@svipas
Copy link
Contributor

svipas commented Mar 15, 2018

Trying to push VS Code team to fix some border issues, even suggested making a PR. This issue will be definitely fixed. Stay tuned :)

Repository owner deleted a comment from svipas Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants