Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New colors after 1.21 version of VS Code #194

Closed
ghost opened this issue Mar 5, 2018 · 5 comments
Closed

New colors after 1.21 version of VS Code #194

ghost opened this issue Mar 5, 2018 · 5 comments

Comments

@ghost
Copy link

ghost commented Mar 5, 2018

Hi, VS Code 1.21 is still not released, but I created this issue as a reminder for myself to create a PR after VS Code will be released.

editorActiveLineNumber.foreground - https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/v1_21.md#coloring-of-active-line-number

notifications / border color of editor highlights / terminal - https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/v1_21.md#new-theme-colors-and-removal-of-old-colors

@jens1o
Copy link
Collaborator

jens1o commented Mar 5, 2018

@bsvipas Fyi you can work with the Insiders version, too. :)

@LordZane
Copy link

LordZane commented Mar 8, 2018

1.21 now released!

@svipas
Copy link
Contributor

svipas commented Mar 8, 2018

@LordZane yes you're right. I will create a PR today. 🎉

EDIT 1:
Selection and active line number colors/borders are done. Left Notifications, but need to create an extension which triggers them to test colors.

EDIT 2:
Created Notification Tester extension for VS Code to test Notification Center and started to work on notifications coloring. https://marketplace.visualstudio.com/items?itemName=svipben.notification-tester

@svipas
Copy link
Contributor

svipas commented Mar 8, 2018

@Binaryify Already created PR: #201

@Binaryify
Copy link
Owner

good job @svipben

Binaryify pushed a commit that referenced this issue Aug 8, 2019
Binaryify pushed a commit that referenced this issue Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants