Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support keyword.operator for C++ #286

Closed
JayXon opened this issue Feb 28, 2019 · 6 comments
Closed

Support keyword.operator for C++ #286

JayXon opened this issue Feb 28, 2019 · 6 comments
Labels
enhancement WIP Work In Process

Comments

@JayXon
Copy link

JayXon commented Feb 28, 2019

When using the Better C++ Syntax extension, it correctly labels the operators in C++, this works for various other themes but the operators lost color when using this theme.

Details at jeff-hykin/better-cpp-syntax#7
@jeff-hykin
Copy link

VS Code just switched their grammar to pull from the Better C++ Syntax extension microsoft/vscode#68392 (comment)
So this now might be a higher priority issue since most operators are currently colored white.

screen shot 2019-03-04 at 10 48 08 am

@Binaryify Binaryify added the WIP Work In Process label Mar 6, 2019
Binaryify pushed a commit that referenced this issue Mar 6, 2019
Improve C++, Markdown syntax highlight #277 #286

Verified

This commit was signed with the committer’s verified signature.
Atul9 Atul Bhosale
GPG key ID: 9CE70EE4DDBEB4A7
Verified
Learn about vigilant mode
5f9bf4c
@Binaryify
Copy link
Owner

@JayXon @jeff-hykin
you can check it now

@JayXon
Copy link
Author

JayXon commented Mar 6, 2019

Still no color on 2.19.1, wrong commit? 5f9bf4c only changed version number

@Binaryify
Copy link
Owner

@JayXon sorry for that, my Mac and my PC project didn't sync

@Binaryify
Copy link
Owner

Binaryify commented Mar 6, 2019 •
edited
Loading

the operator should have right highlight now, please update to v2.19.2

@jeff-hykin
Copy link

Verified working on my end. Thanks 👍

Binaryify pushed a commit that referenced this issue Aug 8, 2019
Improve C++, Markdown syntax highlight #277 #286

Verified

This commit was signed with the committer’s verified signature.
Atul9 Atul Bhosale
GPG key ID: 9CE70EE4DDBEB4A7
Verified
Learn about vigilant mode
6f0aed8
Binaryify added a commit that referenced this issue Aug 8, 2019
@Binaryify
hot fix #286
aca0cdc
Binaryify added a commit that referenced this issue Aug 8, 2019
@Binaryify
Improve C++, Markdown syntax highlight #277 #286
c58e2e1
Binaryify added a commit that referenced this issue Aug 8, 2019
@Binaryify
hot fix #286
63312d7
Binaryify added a commit that referenced this issue Aug 8, 2019
@Binaryify
Improve C++, Markdown syntax highlight #277 #286
3afd178
Binaryify added a commit that referenced this issue Aug 8, 2019
@Binaryify
hot fix #286
5d379b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement WIP Work In Process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JayXon @Binaryify @jeff-hykin