Adjust requirements to use enum-compat in place of enum34 #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this was resolved in 25fa4f4. I am just curious if this is a better solution than just using the compact library which is what I have always done? |
jiajie-chen-havas
added a commit
to jiajie-chen-havas/BingAds-Python-SDK
that referenced
this pull request
Nov 16, 2022
BingAds v13.0.14 has a regression in the versioning for `enum34`. This causes `pip install bingads==13.0.14` to break on Python versions `>=3.4,<3.9`, as it interferes with the `enum` system library. Solution is to revert the change to the `enum34` versioning in `setup.py`. For reference, see: * BingAds#105 * BingAds@25fa4f4 * https://github.com/BingAds/BingAds-Python-SDK/blame/13ae4fde11df8317083038a998ede49f4f9af1f2/setup.py#L18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using enum34 issues can occur on any python version over 3.4. By using this package it will use the standard package on later versions of python. Using enum34 in later versions of python can cause issues with pip itself and break installs.