Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated options for HTSlib dockerfiles #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnmcgonigle
Copy link

A lot of people still use biocontainers so I thought it would be useful to have some updated versions of existing docker files using the new libs.

I've kept the format essentially the same as the previous versions.

@osallou
Copy link
Contributor

osallou commented Aug 7, 2018

can't modify multiple containers in a same pull request

@johnmcgonigle
Copy link
Author

I'm not modifying any containers, I'm adding 3 new ones.

Or is that you can't add 3 containers in a single pull request?

Would you prefer them as 3 separate pull request?

@osallou
Copy link
Contributor

osallou commented Aug 7, 2018

Hi,
We have automatic checks (and previous comment is part of it, though using my id).
Indeed, any container 'new or update' must be in separated pull requests.
If one depends on an other, please just specify it in PR text.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants