0.14.2 labguru fork #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* setup builds to work properly with pinned sqlite3 gem * fix deprecations
Add command to cache bundler gems
* Removing mass assignment * changed > 0 to .positive?
…devise-security#84) * Add documentation about how to properly run wwtd locally
Fixed grammar, spelling, removed shouting.
* Adjust mongoid indexes, fixes devise-security#93
Bump version for release 0.14.0
* Unit tests & refactor of session limitable. Note that the previous implementation would happily save the user record if it was 1) unpersisted, or 2) invalid. Now we update ONLY the appropriate column when updating an invalid record (so we don't accidentally save invalid data) and throw an exception when the record is not already persisted * remove limit from db column * add columns to base migration that were missing (normally these are created by devise)
…ecurity#104) Fixes devise-security#103 Co-authored-by: Kevin Olbrich <22176+olbrich@users.noreply.github.com>
toppa
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small change in
lib/devise-security/models/password_archivable.rbsince upstream0.13.0version so this fork's changes were modified a bit. Branches for0.14.0and0.14.1were also created, but these versions has some bugs in them. See v0.14.1 release notes and v0.14.2 release notesThis PR shouldn't be merged at the moment, but could be approved as the sign of acceptance.