Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated rootcling -c flag, should we get rid of it? #371

Closed
imorlxs opened this issue Jun 26, 2024 · 2 comments · Fixed by #378
Closed

Deprecated rootcling -c flag, should we get rid of it? #371

imorlxs opened this issue Jun 26, 2024 · 2 comments · Fixed by #378
Assignees
Labels
minor-fix Small change for fix ROOT

Comments

@imorlxs
Copy link
Member

imorlxs commented Jun 26, 2024

-c ${ARG_OPTIONS} ${includedirs} ${headerfiles} ${linkdefs}

According to rootcling --help,
-c - Deprecated, legacy flag which is ignored.

Should we get rid of it to simplify the code?

@imorlxs imorlxs changed the title Deprecated -c flag, should we get rid of it? Deprecated rootcling -c flag, should we get rid of it? Jun 26, 2024
This was referenced Jun 26, 2024
@TobiasDuswald
Copy link
Contributor

When did they deprecate it? I suppose if it has been deprecated long enough it should be fine. Feel free and try to remove it, if it crashes in the CI then probably one of the OS still needs the -c

@imorlxs
Copy link
Member Author

imorlxs commented Jul 5, 2024

They deprecated it a long time ago. I can't find the exact date, but it was definitely before 2019. I opened PR #374, and nothing fails (except for Sonar and CentOS workflows).

@imorlxs imorlxs added minor-fix Small change for fix ROOT labels Jul 5, 2024
@imorlxs imorlxs self-assigned this Jul 5, 2024
imorlxs added a commit that referenced this issue Jul 11, 2024
Pull request to close #371.
TobiasDuswald pushed a commit that referenced this issue Jul 22, 2024
imorlxs added a commit that referenced this issue Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-fix Small change for fix ROOT
Projects
None yet
2 participants