Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flocking Demo #240

Merged
merged 16 commits into from
Feb 15, 2022
Merged

Flocking Demo #240

merged 16 commits into from
Feb 15, 2022

Conversation

mhoghrab
Copy link
Contributor

@mhoghrab mhoghrab commented Feb 4, 2022

added a new demo: flocking

Copy link
Contributor

@TobiasDuswald TobiasDuswald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Compiles
  • Runs ( repeated 10 times )
  • Visualizes
  • No compiler warnings
  • Documented well

While the simulation took only 8 seconds, it seems like it took ~10 min
in valgrind.
@TobiasDuswald
Copy link
Contributor

@mhoghrab I changed the copyright notice on top of the *.cc and *.h files in the commit fd9e259. Your authorship (see last line below) is still acknowledged but since the code ends up in the repository it needs to contain the standard header and be distributed under Apache 2.0. I assume that is OK for you?

 // -----------------------------------------------------------------------------
 //
 // Copyright (C) 2022 CERN & University of Surrey for the benefit of the
 // BioDynaMo collaboration. All Rights Reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 //
 // See the LICENSE file distributed with this work for details.
 // See the NOTICE file distributed with this work for additional information
 // regarding copyright ownership.
 //
 // Author: Moritz Grabmann (2022)
 //
 // -----------------------------------------------------------------------------

@TobiasDuswald TobiasDuswald merged commit 6da9e74 into master Feb 15, 2022
@TobiasDuswald TobiasDuswald deleted the flocking branch February 15, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants