Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continuum models #248

Merged
merged 5 commits into from
Mar 14, 2022
Merged

Fix continuum models #248

merged 5 commits into from
Mar 14, 2022

Conversation

nicogno
Copy link
Contributor

@nicogno nicogno commented Mar 11, 2022

  • Reintroduced l[] factors to Euler Diffusion
  • Corrected build target 'run-check'
  • Fixed build target 'coverage-build'

@TobiasDuswald TobiasDuswald self-requested a review March 11, 2022 15:35
TobiasDuswald
TobiasDuswald approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@TobiasDuswald TobiasDuswald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fixes EulerGrid::DiffuseWithOpenEdge
  • Fixes build target coverage-build
  • Fixes documentation for build target run-check

@TobiasDuswald TobiasDuswald merged commit 7b10e4c into BioDynaMo:master Mar 14, 2022
@TobiasDuswald
Copy link
Contributor

Thank you @nicogno for your contribution!

@nicogno nicogno deleted the addLfactorsDiffusion branch March 14, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiasDuswald TobiasDuswald TobiasDuswald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicogno @TobiasDuswald