Demo monolayer growth #278
Conversation
They are in BDM already, avoid code duplication.
Source code only
There was a problem hiding this comment.
Great contribution @nicogno! I marked a few, mostly cosmetic things that would be good to address before merging into the master. I've also added a few commits earlier to remove results and slightly simplify the IO with time series.
Other than that it looks really, really good, let's fix these small things and off to master it goes :)
Adding minor comments.
Added brief comments for what each Setter and Getter is for. Additionally, removed the Vrel setter and getter along with its data members as I believe this is an artefact from the cell cycle specific unit test.
Removed Vrel as it is now redundant.
|
Should we also include a .toml file so that a user of the demo can directly see the simulation outputs ? I dont currently see one and think its a bit of a shame as the simulation itself looks very nice. |
Are you thinking of turning on the ParaView export? Is that what you're saying? I think that would be nice. But we planned on deprecating |
|
Thanks for all the changes Tobias, after passing is this ready to go through or do we still need a few changes ? |
If we are depreciasting toml then yes json would be best. |
change delta t to iterate by one each time step.
|
Kudos, SonarCloud Quality Gate passed!
|
Added monolayer growth demo that simulates the growth of a 2D monolayer as the cells proliferate. Cells go through a whole cycle (G0/G1 -> S -> G2 -> M) and duplicate when their volume has doubled. The growth of the monolayer replicates the experimental data shown in Figure 1 from Drasdo and Hoehme (2005).