[CMake] Replace wget with FetchContent in CMake scripts. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FetchContent doesn't have a progress bar like wget. Instead, it prints messages from 0% to 100%. |
|
It appears that FetchContent creates a new folder, "_deps," with subbuild files. When the macOS workflow attempts to redownload ROOT, the script doesn't detect it. However, the "_deps" folder remains, and no download occurs. To address this issue, I've added a new line to manually delete the folder. However, I'm still looking for a way to prevent its creation in the first place. |
…standard in OS X" This reverts commit 1be7d54.
|
Thanks for your contribution @imorlxs ! |
UmarAbubacar
pushed a commit
that referenced
this pull request
Jun 15, 2024
* [CMake] Replace wget with FetchContent in CMake scripts. * Remove subbuild files. * Deleted dependecies on wget and replaced with curl, which is standard in OS X * Revert "Deleted dependecies on wget and replaced with curl, which is standard in OS X" This reverts commit 1be7d54.
UmarAbubacar
pushed a commit
that referenced
this pull request
Jun 15, 2024
* [CMake] Replace wget with FetchContent in CMake scripts. * Remove subbuild files. * Deleted dependecies on wget and replaced with curl, which is standard in OS X * Revert "Deleted dependecies on wget and replaced with curl, which is standard in OS X" This reverts commit 1be7d54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced the usage of wget with FetchContent in the CMake files. However, I haven't removed it from the dependencies because there are still bash scripts that depend on it.
This helps reduce the dependency on wget at CMake configure time which is non-standard for OSX.