Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test new way of wiring up tests #304

Merged
merged 30 commits into from
Feb 14, 2025
Merged

test new way of wiring up tests #304

merged 30 commits into from
Feb 14, 2025

Conversation

sherwoodf
Copy link
Contributor

@sherwoodf sherwoodf commented Feb 10, 2025

Ticket: https://app.clickup.com/t/8697kxtgx

Scope creep: added a couple of tests that would have caught the recent changes to the api

@sherwoodf sherwoodf marked this pull request as ready for review February 12, 2025 17:43
Copy link
Contributor

@liviuba liviuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to have tests run on the host vs in containers all the time!

Not entirely sure about how service dependencies are set up though

Copy link
Contributor

@liviuba liviuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liviuba liviuba merged commit e31cede into main Feb 14, 2025
21 checks passed
@liviuba liviuba deleted the multi_os_testing branch February 14, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants