Skip to content
This repository has been archived by the owner on Aug 26, 2023. It is now read-only.

[WIP] Decompose Bio.Align and Bio.Intervals #482

Merged
merged 11 commits into from
Aug 7, 2017
Merged

[WIP] Decompose Bio.Align and Bio.Intervals #482

merged 11 commits into from
Aug 7, 2017

Conversation

TransGirlCodes
Copy link
Member

@TransGirlCodes TransGirlCodes commented Jul 20, 2017 •
edited
Loading

This will decompose Bio.Align and Bio.Intervals now that BioAlignments.jl and GenomicFeatures have release versions.

@TransGirlCodes TransGirlCodes changed the title [WIP] Decompose Bio.Align [WIP] Decompose Bio.Align and Bio.Intervals Jul 21, 2017
@codecov-io
Copy link

codecov-io commented Aug 7, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f127343). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #482   +/-   ##
=========================================
  Coverage          ?   70.34%           
=========================================
  Files             ?       34           
  Lines             ?     2421           
  Branches          ?        0           
=========================================
  Hits              ?     1703           
  Misses            ?      718           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f127343...12d92b5. Read the comment docs.

@TransGirlCodes
Copy link
Member Author

This is now passing, also fixes #476.

@TransGirlCodes
Copy link
Member Author

I'll merge shortly if no objections.

bicycle1885
bicycle1885 reviewed Aug 7, 2017
View reviewed changes
src/Align.jl Outdated

using Reexport

@reexport using BioAlignments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not const Align = BioAlignments? I mean Bio.Align is an alias of BioAlignments.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll have to do that for the other modules too in that case, as up until now reexport has been used for them all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

bicycle1885
bicycle1885 approved these changes Aug 7, 2017
View reviewed changes
Copy link
Member

@bicycle1885 bicycle1885 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bicycle1885 bicycle1885 merged commit e08f2a3 into BioJulia:master Aug 7, 2017
@bicycle1885 bicycle1885 mentioned this pull request Aug 7, 2017
Closed
@bicycle1885
Copy link
Member

BTW, Phylogenies.jl is a blocker to support Julia 0.6 on Bio.jl. Any plan to support Julia 0.6?

@TransGirlCodes
Copy link
Member Author

Absolutely, I will update to support 0.6

@TransGirlCodes TransGirlCodes deleted the align-decompose branch August 8, 2017 10:37
joelselvaraj pushed a commit to joelselvaraj/Bio.jl that referenced this pull request Aug 11, 2017
Merge pull request #1 from BioJulia/master
14bc5b7 
Decompose Bio.Align and Bio.Intervals (BioJulia#482)
joelselvaraj pushed a commit to joelselvaraj/Bio.jl that referenced this pull request Aug 11, 2017
Revert "Decompose Bio.Align and Bio.Intervals (BioJulia#482)"
13e8486
joelselvaraj pushed a commit to joelselvaraj/Bio.jl that referenced this pull request Aug 11, 2017
Merge pull request #2 from joels94/revert-1-master
5f4c22d 
Revert "Decompose Bio.Align and Bio.Intervals (BioJulia#482)"
joelselvaraj pushed a commit to joelselvaraj/Bio.jl that referenced this pull request Aug 11, 2017
Merge pull request #3 from BioJulia/master
958afb4 
Decompose Bio.Align and Bio.Intervals (BioJulia#482)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bicycle1885 bicycle1885 bicycle1885 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TransGirlCodes @codecov-io @bicycle1885