Fix array-argument gcd for non-integers

BioTurboNick · Jan 17, 2020 · 3549cd1 · 3549cd1
1 parent 4c58369
commit 3549cd1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/base/intfuncs.jl b/base/intfuncs.jl
@@ -87,9 +87,10 @@ lcm(a::Union{Integer,Rational}, b::Union{Integer,Rational}) = lcm(promote(a,b)..
 gcd(a::Union{Integer,Rational}, b::Union{Integer,Rational}...) = gcd(a, gcd(b...))
 lcm(a::Union{Integer,Rational}, b::Union{Integer,Rational}...) = lcm(a, lcm(b...))
 
+gcd(abc::AbstractArray{<:Union{Integer,Rational}}) = reduce(gcd, abc; init=zero(eltype(abc)))
 lcm(abc::AbstractArray{<:Union{Integer,Rational}}) = reduce(lcm, abc; init=one(eltype(abc)))
 
-function gcd(abc::AbstractArray{<:Union{Integer,Rational}})
+function gcd(abc::AbstractArray{<:Integer})
     a = zero(eltype(abc))
     for b in abc
         a = gcd(a,b)

diff --git a/test/rational.jl b/test/rational.jl
@@ -399,5 +399,7 @@ end
     @test lcm(1//3, 1) == 1//1
     @test lcm(3//1, 1//0) == 3//1
     @test lcm(0//1, 1//0) == 0//1
+
+    @test gcd([5, 2, 1//2]) == 1//2
 end